Miscellaneous Cleanup

.bazelignore

@@ -36,6 +36,7 @@ devtools/common/node_modules
 devtools/flipper/node_modules
 devtools/ui/node_modules
 common/static-xlrs/node_modules
+common/test-utils/node_modules
 cli/node_modules
 
 # Devtools plugins test environment

common/test-utils/BUILD

@@ -0,0 +1,20 @@
+load("@npm//:defs.bzl", "npm_link_all_packages")
+load("@rules_player//javascript:defs.bzl", "js_pipeline")
+load("//helpers:defs.bzl", "tsup_config", "vitest_config")
+
+npm_link_all_packages(name = "node_modules")
+
+tsup_config(name = "tsup_config")
+
+vitest_config(name = "vitest_config")
+
+js_pipeline(
+    private = True,
+    package_name = "@player-tools/test-utils",
+    peer_deps = [
+        "//:node_modules/typescript",
+    ],
+    deps = [
+        "//:node_modules/@typescript/vfs",
+    ],
+)

common/test-utils/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "@player-tools/test-utils",
+    "version": "0.0.0-PLACEHOLDER",
+    "sideEffects": false,
+    "main": "src/index.ts"
+  }
+

common/test-utils/src/index.ts

@@ -0,0 +1 @@
+export * from "./test-helpers";

xlr/utils/src/test-helpers.ts → common/test-utils/src/test-helpers.ts

@@ -15,7 +15,10 @@ export interface SetupReturnType {
 /**
  * Setups a virtual TS environment for tests
  */
-export function setupTestEnv(sourceCode: string, mockFileName = "filename.ts") {
+export function setupTestEnv(
+  sourceCode: string,
+  mockFileName = "filename.ts"
+): SetupReturnType {
   const fsMap = tsvfs.createDefaultMapFromNodeModules({}, ts);
   fsMap.set(mockFileName, sourceCode);
 

pnpm-workspace.yaml

@@ -19,4 +19,5 @@ packages:
   - "devtools/messenger"
   - "devtools/client"
   - "common/static-xlrs"
+  - "common/test-utils"
   - "cli"

xlr/converters/BUILD

@@ -16,6 +16,8 @@ js_pipeline(
     test_deps = [
         "//:node_modules",
         "//:vitest_config",
+        "//:node_modules/@typescript/vfs",
+        ":node_modules/@player-tools/test-utils",
     ],
     deps = [
         ":node_modules/@player-tools/xlr",

xlr/converters/package.json

@@ -4,6 +4,7 @@
   "main": "src/index.ts",
   "dependencies": {
     "@player-tools/xlr": "workspace:*",
-    "@player-tools/xlr-utils": "workspace:*"
+    "@player-tools/xlr-utils": "workspace:*",
+    "@player-tools/test-utils": "workspace:*"
   }
 }

xlr/converters/src/__tests__/player.test.ts

@@ -1,5 +1,5 @@
 import { test, expect } from "vitest";
-import { setupTestEnv } from "@player-tools/xlr-utils";
+import { setupTestEnv } from "@player-tools/test-utils";
 import { TsConverter } from "..";
 
 test("Player Types Export", () => {

xlr/converters/src/__tests__/ts-to-common.test.ts

@@ -1,5 +1,5 @@
 import { test, expect, describe, vi } from "vitest";
-import { setupTestEnv } from "@player-tools/xlr-utils";
+import { setupTestEnv } from "@player-tools/test-utils";
 import { TsConverter } from "..";
 
 describe("Type Exports", () => {

xlr/utils/BUILD

@@ -17,9 +17,9 @@ js_pipeline(
     test_deps = [
         "//:node_modules",
         "//:vitest_config",
+        ":node_modules/@player-tools/test-utils",
     ],
     deps = [
         ":node_modules/@player-tools/xlr",
-        "//:node_modules/@typescript/vfs",
     ],
 )

xlr/utils/package.json

@@ -3,6 +3,7 @@
   "version": "0.0.0-PLACEHOLDER",
   "main": "src/index.ts",
   "dependencies": {
-    "@player-tools/xlr": "workspace:*"
+    "@player-tools/xlr": "workspace:*",
+    "@player-tools/test-utils": "workspace:*"
   }
 }

xlr/utils/src/__tests__/annotations.test.ts

@@ -1,5 +1,5 @@
 import { test, expect, describe } from "vitest";
-import { setupTestEnv } from "../test-helpers";
+import { setupTestEnv } from "@player-tools/test-utils";
 import { decorateNode } from "../annotations";
 
 describe("Annotations", () => {

xlr/utils/src/index.ts

@@ -2,5 +2,4 @@ export * from "./annotations";
 export * from "./ts-helpers";
 export * from "./type-checks";
 export * from "./validation-helpers";
-export * from "./test-helpers";
 export * from "./documentation";