Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Gradle tasks #65

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Support Gradle tasks #65

merged 1 commit into from
Jul 13, 2023

Conversation

ihostage
Copy link
Member

No description provided.

@ihostage ihostage marked this pull request as ready for review July 12, 2023 15:07
@ihostage
Copy link
Member Author

Hi, @mkurz! 👋
I think we are ready to merge this. WDYT?

# Disable caching of ~/.gradle/caches/build-cache-*
save-local-build-cache: false
# Disable caching of ~/.m2/repository/
save-maven-dependencies-cache: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking

  • save-generated-gradle-jars: false and
  • save-gradle-dependencies-cache: false

are not needed? I guess you know what you are doing, just double checking :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the default values of these parameters are OK for us 😉

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK. As long as all the previous, non-gradle things keep working, it should be OK.

- name: Install Adoptium Temurin OpenJDK
uses: coursier/setup-action@v1
with:
jvm: adoptium:${{ inputs.java }}

- name: Publish artifacts
run: sbt ci-release
run: ${{ inputs.cmd }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that, I think I already could have used that in the past.

@mkurz
Copy link
Member

mkurz commented Jul 13, 2023

Feel free to merge / release when you a ready.

@ihostage ihostage merged commit 9f9ea13 into main Jul 13, 2023
@ihostage ihostage deleted the gradle branch July 13, 2023 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants