Upgrade dependencies and upgrade to Go 1.19 #350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ninadingole
approved these changes
May 15, 2023
ninadingole
reviewed
May 15, 2023
|
These issues will be addressed in the PR used to update the playwright version |
ms-htovo
approved these changes
May 18, 2023
ninadingole
approved these changes
May 21, 2023
|
Already merged in #352 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have been working on rolling Playwright to the latest version, but the commit history is not very clear and makes it hard to review the code. Therefore, I decided to split it into several PRs.
This PR mainly does two things: it updates the go version to v1.19 and it fixes some warnings in the github actions.
The reason for updating to go 1.19 is to use the go workspace feature, and also because go 1.19 is the minimum version that is officially supported.