Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lasso and Picker should cooperate #200

Closed
kruus opened this issue Jul 2, 2021 · 3 comments
Closed

Lasso and Picker should cooperate #200

kruus opened this issue Jul 2, 2021 · 3 comments

Comments

@kruus
Copy link

kruus commented Jul 2, 2021

  1. deselections in View Selected currently change this.selected. This means clicking images following n deselected images are out-by-n and display the wrong image. Ex. If you deselect the first image, all remaining ones are out-by-one when asking for the detailed view.
  2. deselections (and new number selected) should get reflected in main display on closing View Selected window
    • currently if you create a new cluster, you get the correct-but-not-as-displayed version.
  3. lasso and picker (Shift + Click) should cooperate (i.e. lasso and shift-click can toggle individual images to the selected ones)
    • I ended up using Ctrl-drag for lasso, iirc, because it was easy for me to make mistakes between Shift-Click and Shift-Drag and lose some possibly detailed work.

Anyway, code was clear enough that I've a decent "good enough for now" version addressing above.

@duhaime
Copy link
Contributor

duhaime commented Jul 2, 2021

Thanks very much for this writeup @kruus! We should be able to clean some of this up next week...

Please keep the issues rolling if you spot other unexpected behavior!

@kruus
Copy link
Author

kruus commented Jul 2, 2021

Maybe you can come up with something cleaner/faster.

Other issue: Does your hotspot scrollbar work? Mine was not appearing. Fixing mostly involved adjusting styles.css width issues and one ugliness for scrollbar height. Mine works now, but my adjustments were super-ugly -- I really just poked at it until it worked.

Excellent timing -- I'm taking vacation next week, while you work on this!

@duhaime duhaime changed the title Several View Selected issues Lasso and Picker should cooperate Aug 26, 2021
@pleonard212
Copy link
Owner

pleonard212 commented Sep 3, 2021

Hi Kruus! Quick question on the scrolling -- sounds like you both don't have a visual scrollbar, and that mousewheel/trackpad drag is not moving the list of hotspots up and down correctly? Also, could you tell us your platform and browser? Thanks!

duhaime added a commit that referenced this issue Sep 17, 2021
allow shift click to toggle images in lasso - closes #200
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants