Fix autocomplete widget with an empty search result (Invalid offset NaN specified) #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user types a string into an autocomplete widget that has no results, an exception is thrown. This fixes this. `Invalid offset NaN specified`
✅ Deploy Preview for volto canceled.
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
sneridagh
approved these changes
Oct 15, 2022
sneridagh
added a commit
that referenced
this pull request
Oct 19, 2022
* master: (22 commits) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release Upgrade dependency rrule (optional dependency luxon removed) (#3781) Fix logout to stay on the same page where the user was (#3739) Object browser: image search should only show images (#3738) Update CHANGELOG.md Update changelog Update branch, docs location add dutch translations Trigger on 6-dev Fix spelling Add action to trigger Plone documentation update Fixed typo for ordinal number at spanish translation Fixed some typos for spanish translation Fixed a msg string translation Fixed a msg string translation Updated spanish translation Updated i18n link into the README file ...
sneridagh
added a commit
that referenced
this pull request
Oct 19, 2022
* master: The listing block icon has been improved to avoid confusions with the normal text list (#3785) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release Upgrade dependency rrule (optional dependency luxon removed) (#3781) Fix logout to stay on the same page where the user was (#3739) Object browser: image search should only show images (#3738) Update CHANGELOG.md
sneridagh
added a commit
that referenced
this pull request
Oct 19, 2022
* master: (23 commits) The listing block icon has been improved to avoid confusions with the normal text list (#3785) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release Upgrade dependency rrule (optional dependency luxon removed) (#3781) Fix logout to stay on the same page where the user was (#3739) Object browser: image search should only show images (#3738) Update CHANGELOG.md Update changelog Update branch, docs location add dutch translations Trigger on 6-dev Fix spelling Add action to trigger Plone documentation update Fixed typo for ordinal number at spanish translation Fixed some typos for spanish translation Fixed a msg string translation Fixed a msg string translation Updated spanish translation ...
sneridagh
added a commit
that referenced
this pull request
Oct 20, 2022
* master: (139 commits) Back to development Release 16.0.0-alpha.44 Prepare for release Solved #3455: SearchTags uses invalid vocabulary API (#3743) The listing block icon has been improved to avoid confusions with the normal text list (#3785) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release Upgrade dependency rrule (optional dependency luxon removed) (#3781) Fix logout to stay on the same page where the user was (#3739) Object browser: image search should only show images (#3738) Update CHANGELOG.md Update changelog Update branch, docs location add dutch translations Trigger on 6-dev Fix spelling Add action to trigger Plone documentation update Fixed typo for ordinal number at spanish translation ...
sneridagh
added a commit
that referenced
this pull request
Oct 24, 2022
* master: Content rules init (#3409) Back to development Release 16.0.0-alpha.44 Prepare for release Solved #3455: SearchTags uses invalid vocabulary API (#3743) The listing block icon has been improved to avoid confusions with the normal text list (#3785) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release Upgrade dependency rrule (optional dependency luxon removed) (#3781) Fix logout to stay on the same page where the user was (#3739) Object browser: image search should only show images (#3738) Update CHANGELOG.md add dutch translations
sneridagh
added a commit
that referenced
this pull request
Oct 24, 2022
* master: (92 commits) Back to development Release 16.0.0-alpha.45 Prepare for release Add a popup tooltip for tokenized options in Select widget values (#3792) TextLine Edit component (#3782) Update the Python minimum requirement to align with README.md and fix… (#3748) fix replace a tag with Universal Link (#3185) Make sure that the store is reset on history reducer `PENDING` state (#3787) Fix changelog Link Integrity (#3317) Content rules init (#3409) Back to development Release 16.0.0-alpha.44 Prepare for release Solved #3455: SearchTags uses invalid vocabulary API (#3743) The listing block icon has been improved to avoid confusions with the normal text list (#3785) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user types a string into an autocomplete widget that has no results, an exception is thrown. This fixes this problem.
Invalid offset NaN specified