Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

debug histograms in ggplot API #751

Closed
edublancas opened this issue Jul 20, 2023 · 2 comments · Fixed by #754
Closed

debug histograms in ggplot API #751

edublancas opened this issue Jul 20, 2023 · 2 comments · Fixed by #754
Assignees

Comments

@edublancas
Copy link

we need to ensure that we're correctly computing the histograms. I noticed that that shapes differ vs what we see in R: #711 (review)

@bbeat2782
Copy link

bbeat2782 commented Jul 20, 2023

Acceptance Criteria

  1. Modify sql query code to mimic how ggplot in R divides continuous variables into bins when plotting histogram.
  2. Compare all histograms in test images to make sure we are getting the same histograms from R and jupysql.
  3. Update histogram test images.

@edublancas
Copy link
Author

Modify sql query code to mimic how ggplot in R divides continuous variables into bins when plotting histogram.

there's no need to ensure that our histograms match R's histograms 100%, instead we should ensure that our histograms are accurate (they plot what they're supposed to plot). It's fine if there are small differences with respect to R, but those differences should be methodical (i.e., how we compute bins), but still produce accurate histograms

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants