-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ggplot histogram query change #754
ggplot histogram query change #754
Conversation
I checked the shape of histograms in the test files with ggplot in R, and they match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some comments in your code? looks like you made some adjustments to the histogram computation, let's ensure it's properly explained what we're doing it (mention we want to mimic what ggplot in R does + explaining each change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @edublancas.
We might also consider adding some information to our docs about how we calculate the bins and compare it with R to increase trust.
integration histograms update revert histogram_categorical comments
@edublancas @yafimvo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbeat2782 Good job!
Describe your changes
Changed how histogram binning query works so that it mimics R ggplot behavior.
Issue number
Closes #751
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--754.org.readthedocs.build/en/754/