%sqlcmd improvements #341
Merged
%sqlcmd improvements #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionality + documentation should be all finished, only thing I'm still having trouble implementing is using |
|
Resolve the conflict? |
# This is the 1st commit message: initial commit # This is the commit message ploomber#2: comparator check # This is the commit message ploomber#3: remove test # This is the commit message ploomber#4: temp temp column not found format # This is the commit message ploomber#5: edits remove comments concise remove comments # This is the commit message ploomber#6: print values
comparator check remove test temp temp column not found format edits remove comments concise remove comments print values integration tests fix lint added quotes for test integration test fix fix docs fix documentation, changelog
gtduncan
force-pushed
the
george-sqlcmb-improvements
branch
from
7d234f1 to
7d7ed83
Compare
|
Should be resolved now |
gtduncan
added
allow-workflow-edits
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improving user experience for %sqlcmd, more specific errors
Issue number
Closes #275
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--341.org.readthedocs.build/en/341/