Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate user feedback to use display module #735

Conversation

anupam-tiwari
Copy link

@anupam-tiwari anupam-tiwari commented Jul 14, 2023

Describe your changes

Replaced all the prints to display module

Closes #548

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--735.org.readthedocs.build/en/735/

@anupam-tiwari anupam-tiwari added no-changelog This PR doesn't require a changelog entry and removed no-changelog This PR doesn't require a changelog entry labels Jul 14, 2023
@anupam-tiwari
Copy link
Author

@edublancas does this look good?

Copy link

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edublancas edublancas merged commit c1f9cdf into ploomber:master Jul 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate user feedback to use display module
3 participants