Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Twice message printing when switching to the current connection #773

Closed

Conversation

anupam-tiwari
Copy link

@anupam-tiwari anupam-tiwari commented Jul 31, 2023

Describe your changes

Issue number

Closes #772

Checklist before requesting a review

  • Performed a self-review of my code
  • Formatted my code with pkgmt format
  • Added tests (when necessary).

📚 Documentation preview 📚: https://jupysql--773.org.readthedocs.build/en/773/

@anupam-tiwari anupam-tiwari marked this pull request as ready for review August 7, 2023 21:25
@anupam-tiwari
Copy link
Author

@edublancas @neelasha23 does this look good?

@neelasha23
Copy link

This still looks like a bug? There should be message when swithcing to sqlite?
Screenshot 2023-08-08 at 6 25 01 PM

@edublancas
Copy link

@anupam-tiwari yes, there is still a bug. if a user tries to switch to the same connection, the message should not appear. if you try to switch to a different one, it should.

@anupam-tiwari
Copy link
Author

looking into it!

@anupam-tiwari anupam-tiwari deleted the twice-message-printing branch August 11, 2023 20:08
@edublancas
Copy link

@anupam-tiwari please avoid closing PRs, especially when there are reviews already as this loses the context from existing reviews.

@anupam-tiwari
Copy link
Author

@anupam-tiwari please avoid closing PRs, especially when there are reviews already as this loses the context from existing reviews.

so sorry about that, I messed up my local repo so had to delete it, will keep in mind!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message is printed twice when switching to the current connection
3 participants