-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Twice message printing when switching to the current connection #773
Twice message printing when switching to the current connection #773
Conversation
@edublancas @neelasha23 does this look good? |
@anupam-tiwari yes, there is still a bug. if a user tries to switch to the same connection, the message should not appear. if you try to switch to a different one, it should. |
looking into it! |
@anupam-tiwari please avoid closing PRs, especially when there are reviews already as this loses the context from existing reviews. |
so sorry about that, I messed up my local repo so had to delete it, will keep in mind! |
Describe your changes
Issue number
Closes #772
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--773.org.readthedocs.build/en/773/