Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

improves postgres compatibility + more granular feedback config #798

Merged
merged 25 commits into from
Aug 14, 2023
Merged

improves postgres compatibility + more granular feedback config #798

merged 25 commits into from
Aug 14, 2023

Conversation

edublancas
Copy link

@edublancas edublancas commented Aug 14, 2023 •
edited
Loading

Describe your changes

  • [Fix] Perform ROLLBACK when SQLAlchemy raises PendingRollbackError
  • [Fix] Perform ROLLBACK when psycopg2 raises current transaction is aborted, commands ignored until end of transaction block
  • [Fix] Perform ROLLBACK when psycopg2 raises server closed the connection unexpectedly (closes connection closed when using postgres #677)
  • [Fix] Shorter displaylimit footer
  • [API Change] %config SqlMagic.feedback now takes values 0 (disabled), 1 (normal), 2 (verbose)
  • [Fix] ResultSet footer only displayed when feedback=2
  • [Fix] Current connection and switching connections message only displayed when feedback>=1
  • [Fix] --persist/--persist-replace perform ROLLBACK automatically when needed

Checklist before requesting a review

📚 Documentation preview 📚: https://jupysql--798.org.readthedocs.build/en/798/

@edublancas
improved support for postgres
69b3c26
@edublancas
fix
4e25aff
@edublancas
test updates
0fe19da
@edublancas
update changelog
bcf4e2e
@edublancas
typo
9af2a95
@edublancas
deletes old comment
a46b04d
@edublancas
adds a generic way to access the magic instance, the feedback config …
5a83b12 
…can hide the resultset footer
@edublancas
shorter displaylimit footer
8ad566a
@edublancas
feedback config controls displaying switching connections and current…
0b36bbc 
… connection
@edublancas
update changelog
cbe40eb
@edublancas
fix version
938b44f
@edublancas
test fix
5a129bd
@edublancas
documentation updates
1558567
@edublancas
cleanup
d4f9a27
@edublancas
moves data frame persist logic to connection, and creates method to h…
887822a 
…andle sqlalchemy errors
@edublancas
fix
7b18484
@edublancas
--persist/--persist-replace perform ROLLBACK automatically when n…
2b32963 
…eeded
@edublancas
changelog
87acd7d
@edublancas
testing error when using --persist/--persist-replace with dbapi conne…
4e120a3 
…ctions
@edublancas
testing --persist uses error handling method
f9c8946
@edublancas
adds some missing comments
4a25a93
@edublancas
fix
902075a
@edublancas edublancas changed the title Dev/postgres improves postgres compatibility Aug 14, 2023
@edublancas edublancas changed the title improves postgres compatibility improves postgres compatibility + more granular feedback config Aug 14, 2023
@edublancas edublancas marked this pull request as ready for review August 14, 2023 04:53
@edublancas edublancas requested a review from neelasha23 as a code owner August 14, 2023 04:53
@neelasha23
Copy link

Added minor comments. Looks good otherwise

@edublancas edublancas requested a review from neelasha23 August 14, 2023 14:41
@edublancas edublancas merged commit ab891e1 into master Aug 14, 2023
@edublancas edublancas deleted the dev/postgres branch August 14, 2023 16:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@neelasha23 neelasha23 neelasha23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connection closed when using postgres
2 participants
@edublancas @neelasha23