Remove duplicate package.json, update readme. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ | |||
| _sys.exit(1) | |||
|
|
|||
| _basepath = _os.path.dirname(__file__) | |||
| _filepath = _os.path.abspath(_os.path.join(_basepath, 'package.json')) | |||
| _filepath = _os.path.abspath(_os.path.join(_basepath, '..','package.json')) | |||
There was a problem hiding this comment.
Hmm will this actually work once the package is installed via pip?
There was a problem hiding this comment.
Maybe this is why that copyfile was there?
There was a problem hiding this comment.
I'll add a test that will package the build and run an app with it installed as a tarball.
| from setuptools import setup | ||
|
|
||
|
|
||
| with open(os.path.join('{{cookiecutter.project_shortname}}', 'package.json')) as f: | ||
| with open('package.json') as f: |
| @@ -9,7 +9,7 @@ | |||
| "prepublish": "npm run validate-init", | |||
| "build:js-dev": "webpack --mode development", | |||
| "build:js": "webpack --mode production", | |||
| "build:py": "node ./extract-meta.js src/lib/components > {{cookiecutter.project_shortname}}/metadata.json && copyfiles package.json {{cookiecutter.project_shortname}} && %(python_path) -c \"import dash; dash.development.component_loader.generate_classes('{{cookiecutter.project_shortname}}', '{{cookiecutter.project_shortname}}/metadata.json')\"", | |||
| "build:py": "node ./extract-meta.js src/lib/components > {{cookiecutter.project_shortname}}/metadata.json && %(python_path) -c \"import dash; dash.development.component_loader.generate_classes('{{cookiecutter.project_shortname}}', '{{cookiecutter.project_shortname}}/metadata.json')\"", | |||
There was a problem hiding this comment.
see my comment in plotly/dash#451
|
In principle this is mergable once we clear up the need for |
|
Closing as outdated. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsonand it's reference.package.jsonreferences with root.Closes #30, Close #31