Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Issue 788 - dcc.Dropdown dropdown should have priority over table fixed rows/columns #790

Merged
merged 8 commits into from
Apr 27, 2020

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Apr 9, 2020

Closes #788

Default z-index for .Select-menu-outer is 1. Better to increase it than to use 0 and negative z-index throughout the table.

@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review April 9, 2020 21:33
@alexcjohnson
Copy link
Collaborator

Agreed that this is the best approach. Do we have an upper bound for z-index based on modals perhaps, either here or ddk? Is 1000 OK for these?

@Marc-Andre-Rivet
Copy link
Contributor Author

Marc-Andre-Rivet commented Apr 20, 2020

@alexcjohnson DDK modals have z-index:1011 and the backdrop has z-index: 1010

Apart from modals very few things should take priority over an open menu (eg. maybe a tooltip on said menu?), 1000 sounds appropriate in this case.

@alexcjohnson
Copy link
Collaborator

OK good. dbc.Modal uses 1050 by default which is also compatible

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 after minor comment about the test name.

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 5aa0ea8 into dev Apr 27, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header z-index is larger than dcc.Dropdown z-index
2 participants