This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed default props that were not typed
@xhlulu please drop package-lock.json from this PR, since you aren't updating package.json. If you do change package.json, note that dash core is now using node 16 / npm 7 |
7c98b61
to
cbfb31e
Compare
Pass a bbox through graph hover data
Sure. I removed the commit that added |
This is outdated since absolute tooltip improves upon this
Remove some z-index positioning that were not relevant, change the props
It's not clear how those props will be used and could be confusing. It's better to remove them for now and add them later if needed
723be9e
to
bbdbbcb
Compare
AbsoluteTooltip.css has been superceded by style jsx
@alexcjohnson am I supposed to commit |
@alexcjohnson I feel this PR is ready for review. A few questions for review:
|
When loading, the component will display the loading_text, otherwise it will show the props.children
This was referenced Aug 25, 2021
Closed
Closing - will remake shortly in the monorepo |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated attempt for: #940
Note #941 was also added to this PR in 6a18fd9
Related:
TODOs for demo: