This repository was archived by the owner on Jun 4, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 49
No events v1 #90
Merged
Merged
No events v1 #90
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
d992238
prepublish -> prepare / prepublishOnly.
rmarren1 d98520f
Lock dash>=0.32.2
T4rk1n 55da61e
Regenerate
T4rk1n 7e6f7d2
Update version and changelog.
T4rk1n ab1aaa4
Merge pull request #85 from plotly/fix-build
T4rk1n fa7e839
Improve npmignore
T4rk1n 66a1c41
Add url to setup.py
T4rk1n 9fd2e4c
Update changelog.
T4rk1n 20df128
Add long_description.
T4rk1n ffafd9b
Merge pull request #86 from plotly/fix-ignores
T4rk1n c51ed1a
Merge pull request #83 from plotly/prepublish
rmarren1 37febab
lint generate-components
alexcjohnson 173510e
npm test shortcut
alexcjohnson 2f873da
ensure element list is unique
alexcjohnson 887846f
remove events from generate-components script
alexcjohnson 599d98c
rebuild
alexcjohnson a2e145e
update changelog
alexcjohnson bdfbb5c
add PR number to changelog for :hocho: events
alexcjohnson eb3c4de
lint scripts dir
alexcjohnson 82695c1
simplify ci command & include lint
alexcjohnson f469338
bump version to 0.13.5
52b049d
set +e along with lint and test errors
alexcjohnson 3ad1dd3
fix lint error only - still has test error
alexcjohnson 2930061
remove set +e
alexcjohnson 15d2891
set +e and +o pipefail - still failing test only, not lint
alexcjohnson e42be85
new approach: npm-run-all -> run-s
alexcjohnson f28aede
remove fake test error
alexcjohnson 89a6d67
Merge pull request #89 from plotly/no-events
alexcjohnson b922988
Merge branch 'master' into no-events-v1
alexcjohnson 305ad15
underscore more vars in init.py
alexcjohnson be67099
mention 0.x version bump in 1.0 branch changelog
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,7 @@ venv/ | |
*.pyc | ||
*.log | ||
.DS_Store | ||
|
||
.idea | ||
tests | ||
dist | ||
.circleci |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the good practice would be here but I'd like something to let me know there is something unreleased in this v1.x branch so I can keep track of v1 releases states vs v0 if there's a need for it.
Maybe adding [Unreleased] entry at the top, referring to the 0.13.4 & 0.13.5 version bumps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right I meant to bring up the changelog - it's a little funny since the history isn't quite linear but your idea seems like the most useful approach -> be67099
To be removed/cleaned up once we have a new rc release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcjohnson Yes exactly. Once in rc, we can collapse the entire alpha history, same thing happens to the rc's once we do an official release.