Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Fix 'child in a list should have a unique key prop' #690

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix 'child in a list should have a unique key prop' #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
</head>
<body>
<div id='root'></div>
<script src='https://unpkg.com/react@16.8.6/umd/react.production.min.js'></script>
<script src='https://unpkg.com/react-dom@16.8.6/umd/react-dom.production.min.js'></script>
<script src='https://unpkg.com/react@16.8.6/umd/react.development.js'></script>
<script src='https://unpkg.com/react-dom@16.8.6/umd/react-dom.development.js'></script>

<script src="./demo.js"></script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion src/dash-table/components/ControlledTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
>
{arrayMap3(row, gridStyle[rowIndex], fragmentClasses[rowIndex], (g, s, c, columnIndex) => (<div
style={s.fragment}
key={columnIndex}
key={`row--${rowIndex}--column--${columnIndex}`}
ref={`r${rowIndex}c${columnIndex}`}
className={`cell cell-${rowIndex}-${columnIndex} ${c}`}
>
Expand Down
7 changes: 4 additions & 3 deletions src/dash-table/derived/cell/contents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class Contents {
switch (cellType) {
case CellType.Dropdown:
return (<CellDropdown
key={`column-${columnIndex}`}
key={`dp-row-${rowIndex}-column-${columnIndex}`}
active={active}
applyFocus={applyFocus}
clearable={dropdown && dropdown.clearable}
Expand All @@ -154,7 +154,7 @@ class Contents {
/>);
case CellType.Input:
return (<CellInput
key={`column-${columnIndex}`}
key={`ci-row-${rowIndex}-column-${columnIndex}`}
active={active}
applyFocus={applyFocus}
className={className}
Expand All @@ -167,6 +167,7 @@ class Contents {
/>);
case CellType.Markdown:
return (<CellMarkdown
key={`cm-row-${rowIndex}-column-${columnIndex}`}
active={active}
applyFocus={applyFocus}
className={className}
Expand All @@ -183,7 +184,7 @@ class Contents {
active={active}
applyFocus={applyFocus}
className={className}
key={`column-${columnIndex}`}
key={`cl-row-${rowIndex}-column-${columnIndex}`}
value={resolvedValue}
/>);
}
Expand Down
2 changes: 1 addition & 1 deletion src/dash-table/derived/cell/wrappers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class Wrappers {
'data-dash-row': rowIndex
}}
classes={classes}
key={`column-${columnIndex}`}
key={`row-${rowIndex}-column-${columnIndex}`}
onClick={onClick}
onDoubleClick={onDoubleClick}
onMouseEnter={onEnter}
Expand Down
2 changes: 1 addition & 1 deletion src/dash-table/derived/header/wrappers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function getter(
}

return (<th
key={`header-cell-${columnIndex}`}
key={`header-cell-${columnIndex}--${column.id}`}
data-dash-column={column.id}
colSpan={colSpan}
className={
Expand Down