Skip to content

Commit

Permalink
remove webdriver-manager
Browse files Browse the repository at this point in the history
I think this was really just a misunderstanding of the cimg CI images
  • Loading branch information
alexcjohnson committed Feb 17, 2022
1 parent 5b3745d commit 9e92714
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
15 changes: 2 additions & 13 deletions dash/testing/browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
MoveTargetOutOfBoundsException,
)

from webdriver_manager.chrome import ChromeDriverManager
from webdriver_manager.utils import ChromeType
from webdriver_manager.firefox import GeckoDriverManager

from dash.testing.wait import text_to_equal, style_to_equal, contains_text, until
from dash.testing.dash_page import DashPageMixin
from dash.testing.errors import DashAppLoadingError, BrowserError, TestingTimeoutError
Expand Down Expand Up @@ -477,11 +473,7 @@ def _get_chrome(self):
desired_capabilities=capabilities,
)
if self._remote
else webdriver.Chrome(
ChromeDriverManager(chrome_type=ChromeType.GOOGLE).install(),
options=options,
desired_capabilities=capabilities,
)
else webdriver.Chrome(options=options, desired_capabilities=capabilities)
)

# https://bugs.chromium.org/p/chromium/issues/detail?id=696481
Expand Down Expand Up @@ -524,10 +516,7 @@ def _get_firefox(self):
)
if self._remote
else webdriver.Firefox(
executable_path=GeckoDriverManager().install(),
firefox_profile=fp,
options=options,
capabilities=capabilities,
firefox_profile=fp, options=options, capabilities=capabilities
)
)

Expand Down
1 change: 0 additions & 1 deletion requires-testing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ pytest>=6.0.2
requests[security]>=2.21.0
selenium>=3.141.0
waitress>=1.4.4
webdriver-manager>=3.5.1

0 comments on commit 9e92714

Please # to comment.