Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include license in the sdist of dash-renderer #1171

Closed
wants to merge 1 commit into from
Closed

Include license in the sdist of dash-renderer #1171

wants to merge 1 commit into from

Conversation

scarabeusiv
Copy link

This will ensure the pkg has a license shipped even if people fetch the package from pypi.

This will ensure the pkg has a license shipped even if people fetch the package from pypi.
@alexcjohnson
Copy link
Collaborator

Does this work? We don't have a LICENSE file in the dash-renderer dir, only at the repo root.

@scarabeusiv
Copy link
Author

Hmm True I just blinly copied it out from other package I was doing this for during that day. Maybe it should contain ../LICENSE as to deal with the path.

@scarabeusiv
Copy link
Author

I am now on mobile and could fix it later next week, but I gave dev access to the branch or as it is oneliner just do it from scratch and revoke this one :)

@alexcjohnson
Copy link
Collaborator

Is there a use case for fetching dash-renderer from PyPI? Normally it's just used internally by dash, and we've been discussing simply folding dash-renderer into the dash package. Originally I think we kept them separate in order to facilitate using the dash-renderer front end with different back ends, but the other back ends that I'm aware of just grab the built renderer bundle from this repo one way or another.

That said we also publish dash-renderer to npm and will continue to do so for the serve_locally=False case, that alone probably warrants a LICENSE and a lightweight README.

@alexcjohnson
Copy link
Collaborator

As of #1611, the dash-renderer pypi package is no longer separate from dash, so this issue is moot.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants