Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sort also the directory name for proper ordering between css and js plugin folders #1185

Merged
merged 3 commits into from
May 15, 2020
Merged

Sort also the directory name for proper ordering between css and js plugin folders #1185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b42e411
Sort also the directory name for proper ordering between css and js p…
nikalexis Apr 9, 2020
6a5fad0
Merge branch 'dev' into winnerNick-dev
alexcjohnson May 15, 2020
52eb81c
changelog for asset directory sorting
alexcjohnson May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#1249](https://github.com/plotly/dash/pull/1249) Fixes [#919](https://github.com/plotly/dash/issues/919) so `dash.testing` is compatible with more `pytest` plugins, particularly `pytest-flake8` and `pytest-black`.
- [#1248](https://github.com/plotly/dash/pull/1248) Fixes [#1245](https://github.com/plotly/dash/issues/1245), so you can use prop persistence with components that have dict IDs, ie for pattern-matching callbacks.
- [#1185](https://github.com/plotly/dash/pull/1185) Sort asset directories, same as we sort files inside those directories. This way if you need your assets loaded in a certain order, you can add prefixes to subdirectory names and enforce that order.

## [1.12.0] - 2020-05-05
### Added
Expand Down
2 changes: 1 addition & 1 deletion dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ def _walk_assets_directory(self):
ignore_str = self.config.assets_ignore
ignore_filter = re.compile(ignore_str) if ignore_str else None

for current, _, files in os.walk(walk_dir):
for current, _, files in sorted(os.walk(walk_dir)):
if current == walk_dir:
base = ""
else:
Expand Down