Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1216
Pattern-matching callbacks had some issues with
ALL
wildcards in theirOutput
, reported by user@jaser
on the forum. Everything worked well as long as theALL
matched something, but if it didn't we would throw an error.There are a number of additional cases to consider, involving various combinations of
ALL
andMATCH
wildcards and multiple outputs, as enumerated in #1216 - I will comment on the tests which of these cases each covers. And as discussed in #1216, we will NOT trigger a callback simply because one or more output items was removed. If you want that to happen, include the output component set as inputs as well - our suggestion is to just change the prop to'id'
to avoid circular dependencies, and as a side benefit you get a clean list of the IDs involved.CHANGELOG.md