Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

hard reload targets just this window #1255

Merged
merged 5 commits into from
May 20, 2020
Merged

hard reload targets just this window #1255

merged 5 commits into from
May 20, 2020

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented May 16, 2020 •
edited
Loading

For some reason we had window.top.location.reload() for dev tools hot reloading - but if your app is in an iframe there's no reason you need (or want!) the parent to reload, is there?

  • Extend existing hot reload test to cover both soft and hard reload. I don't really feel the need to test the iframe case though - seems like a huge hassle for something we're not likely to mess with again. Reasonable?
  • I have added entry in the CHANGELOG.md

chriddyp
chriddyp approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@chriddyp chriddyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 looks great!

@alexcjohnson alexcjohnson merged commit cfebe38 into dev May 20, 2020
@alexcjohnson alexcjohnson deleted the reload-window branch May 20, 2020 15:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chriddyp chriddyp chriddyp approved these changes

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcjohnson @chriddyp