Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1143 - with the help of companion PRs in the various component repos. (In principle we should do this for all component repos as well as the boilerplate)
Through a confusing set of circumstances described in #1143, having a Python file with one of several common names in your directory (but NOT
dash.py
) which imports any dash component package causes a circular import of dash itself, which manifests as failing the "make sure you don't have adash.py
file in your directory" check in the__init__.py
of the component package, becausedash
hasn't finished importing so doesn't have the attributes we're looking for.I'm tempted to delete these checks entirely - if we did that, the circumstance described above would work fine, but when you do make a
dash.py
you'd see the error message:Which is essentially what you'd see if you did this with any other Python package -
import pandas
when you have a filepandas.py
for example.And if we ever end up combining packages this whole business will be moot, as you'll never get to the point of generating this error. Still, for now these changes should solve the issue.
Contributor Checklist
CHANGELOG.md