Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable compression by default in Dash 2 #1707

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Conversation

jonmmease
Copy link
Contributor

This PR changes the default value of the compress argument to the dash.Dash constructor from True to False.

Rational: Compression has a performance penalty, and is often handled at a higher level in the deployment stack (e.g. by NGINX or Dash Enterprise). This PR makes Flask-level compression opt-in rather than opt-out for Dash 2.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

dash/dash/dash.py

Lines 199 to 200 in abfd9a8

:param compress: Use gzip to compress files and data served by Flask.
Default ``True``

Plus a changelog entry.

Then this is good to go 💃

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants