Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dep updates 220412 #2016

Merged
merged 17 commits into from
Apr 15, 2022
Merged

Dep updates 220412 #2016

merged 17 commits into from
Apr 15, 2022

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Apr 15, 2022

Dependency upgrades in both JS and Python in all sub-packages. Mostly simple and uncontroversial, but note:

  • black - had only minor effects on our codebase but the latest version depends on click>=8 which is unsupported by the version of celery we need in Py3.6. Still installing black with dash[ci] on Py3.6 (so you can still build Dash itself there) but not running it on CI.
  • pylint - the rule consider-using-f-string now defaults to a blocker and I chose to go for it - f-strings everywhere! except R and Julia component generators I exempted because I wasn't sure they're well-tested.

On the JS side there are various major version bumps I did not attempt (including react 18, which is now out!)
Here's the output from node-check-updates (ncu) on the major pieces - with a few notes about issues I ran into:

Checking /Users/alex/plotly/dash/package.json
All dependencies match the latest package versions :)

Checking /Users/alex/plotly/dash/components/dash-core-components/package.json
 @fortawesome/fontawesome-svg-core      1.2.36  →    6.1.1
 @fortawesome/free-regular-svg-icons   ^5.15.4  →   ^6.1.1
 @fortawesome/free-solid-svg-icons     ^5.15.4  →   ^6.1.1
 @fortawesome/react-fontawesome        ^0.1.17  →  ^0.1.18
 d3-format                              ^1.4.5  →   ^3.1.0  # Matches plotly.js version, though I'm not sure how important that is
 rc-slider                              ^9.7.5  →  ^10.0.0
 react-dropzone                         ^4.1.2  →  ^12.0.5
 react-markdown                         ^4.3.1  →   ^8.0.2
 react-resize-detector                  ^6.7.6  →   ^7.0.0
 remark-math                            ^3.0.1  →   ^5.1.1
 react                                ^16.14.0  →  ^18.0.0
 react-dom                            ^16.14.0  →  ^18.0.0
 react-jsx-parser                       1.21.0  →   1.29.0  # Previously encountered an issue here, did not try again now
 styled-jsx                             ^3.4.4  →   ^5.0.2

Checking /Users/alex/plotly/dash/components/dash-html-components/package.json
 react      ^17.0.2  →  ^18.0.0
 react-dom  ^17.0.2  →  ^18.0.0

Checking /Users/alex/plotly/dash/components/dash-table/package.json
 @fortawesome/fontawesome-svg-core      1.2.36  →    6.1.1
 @fortawesome/free-regular-svg-icons   ^5.15.4  →   ^6.1.1
 @fortawesome/free-solid-svg-icons     ^5.15.4  →   ^6.1.1
 @fortawesome/react-fontawesome        ^0.1.17  →  ^0.1.18
 @percy/storybook                       ^3.3.1  →   ^4.2.0
 @types/react                         ^16.14.8  →  ^18.0.5
 @types/react-dom                     ^16.9.13  →  ^18.0.1
 @types/react-select                   ^4.0.16  →   ^5.0.0
 react                                ^16.14.0  →  ^18.0.0
 react-dom                            ^16.14.0  →  ^18.0.0
 react-select                           ^1.3.0  →   ^5.3.0
 webpack-dev-server                    ^3.11.2  →   ^4.8.1
 xlsx                                  ^0.17.5  →  ^0.18.5  # Latest seemed to work fine but somehow I could not get it to build as ES5

Checking /Users/alex/plotly/dash/dash/dash-renderer/package.json
 react          16.14.0  →   18.0.0
 react-dom      16.14.0  →   18.0.0
 @types/react  ^16.14.8  →  ^18.0.5
  • I have added entry in the CHANGELOG.md

@alexcjohnson alexcjohnson merged commit 0d3ade5 into dev Apr 15, 2022
@alexcjohnson alexcjohnson deleted the dep-updates-220412 branch April 15, 2022 15:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant