Fix callback output of ndarray and no_update check. #2175

T4rk1n · 2022-08-01T16:40:22Z

alexcjohnson · 2022-08-01T21:36:17Z

tests/integration/callbacks/test_basic_callback.py

+
+
+def test_cbsc018_callback_ndarray_output(dash_duo):
+    import numpy as np


move import to the top?

dash/_callback.py

alexcjohnson

💃 just two minor style comments. Looks good! This kind of problem must happen all the time when using == with something that might be a numpy array... very annoying.

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

T4rk1n added 2 commits August 1, 2022 12:13

Add test callback ndarray output

f14283b

Fix is_no_update with numpy outputs.

bdecc65

T4rk1n requested a review from alexcjohnson as a code owner August 1, 2022 16:40

Update changelog.

ae5f60c

alexcjohnson reviewed Aug 1, 2022

View reviewed changes

dash/_callback.py Outdated Show resolved Hide resolved

alexcjohnson approved these changes Aug 1, 2022

View reviewed changes

T4rk1n and others added 2 commits August 2, 2022 10:01

Update dash/_callback.py

249c934

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

Format and move import.

73c80cf

T4rk1n force-pushed the fix-no-update-np branch from f26ee35 to 73c80cf Compare August 2, 2022 14:55

T4rk1n merged commit 8453bdd into dev Aug 2, 2022

T4rk1n deleted the fix-no-update-np branch August 2, 2022 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix callback output of ndarray and no_update check. #2175

Fix callback output of ndarray and no_update check. #2175

T4rk1n commented Aug 1, 2022

alexcjohnson Aug 1, 2022

alexcjohnson left a comment



		def test_cbsc018_callback_ndarray_output(dash_duo):
		import numpy as np

Fix callback output of ndarray and no_update check. #2175

Fix callback output of ndarray and no_update check. #2175

Conversation

T4rk1n commented Aug 1, 2022

alexcjohnson Aug 1, 2022

Choose a reason for hiding this comment

alexcjohnson left a comment

Choose a reason for hiding this comment