Fix Dropdown useMemo not detecting equal objects #2293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests improves the performance of the dash core component dropdown.
The
useMemo
didn't recognize that the objects inside theoptions
array of the dropdown stayed the same, so theuseMemo
got recalculated all the time.Because of this Dropdowns with a lot of values inside (I have some with >1k) took a lot of time to render(>100ms).
Using the
useRef
the currentoptions
-object(and the address associated with that) are saved and compared with the newoptions
-object is deep compared to that one usingisEqual
from react-fast-compare.That way the
persistentOptions
is only changed when the options change, and that way theuseMemo
is only executed when needen.Contributor Checklist
optionals
CHANGELOG.md