Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update docstring for pages_folder #2468

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Update docstring for pages_folder #2468

merged 5 commits into from
Apr 20, 2023

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Mar 17, 2023 •
edited
Loading

Updates docstring based on
#2392

Adds pages_folder supports relative and absolute paths and pathlib.Path instances

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@LiamConnors LiamConnors marked this pull request as ready for review March 17, 2023 19:35
@LiamConnors LiamConnors requested a review from T4rk1n March 17, 2023 19:36
T4rk1n
T4rk1n approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@LiamConnors
Copy link
Member Author

@alexcjohnson or @T4rk1n I don't have permission to merge this. Could you merge it for me?

@T4rk1n T4rk1n merged commit 833f72d into dev Apr 20, 2023
@T4rk1n T4rk1n deleted the update-docstring branch April 20, 2023 20:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiamConnors @T4rk1n