Fix allow_duplicate output with clientside callback. #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # tests/integration/test_patch.py
chriddyp
reviewed
Mar 28, 2023
tests/integration/test_patch.py
Outdated
| prevent_initial_call=True, | ||
| ) | ||
| app.clientside_callback( | ||
| "function onClickTwo(){ return 'click2';}", |
There was a problem hiding this comment.
Would a more comprehensive test be to have an anonymous function? To test the uuid.uuid4.hex() thing as above. So like () => { return 'click2' }?
There was a problem hiding this comment.
Not really, the function name is actually discarded/unimportant when the script inline, I had fixed on the rendered first but the test still failed so I tried a few thing like adding name on the function to found out where it was getting the name and replaced with the hex.
chriddyp
approved these changes
Mar 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2467