Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(dash-table): added key prop to markdown cell 🐛 #2596

Merged
merged 4 commits into from
Jul 20, 2023
Merged

fix(dash-table): added key prop to markdown cell 🐛 #2596

merged 4 commits into from
Jul 20, 2023

Conversation

alexjercan
Copy link
Contributor

@alexjercan alexjercan commented Jul 12, 2023 •
edited
Loading

This PR fixes #1433

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • change the markdown cell to include the key prop
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@alexjercan alexjercan requested a review from alexcjohnson as a code owner July 12, 2023 07:58
@T4rk1n
Copy link
Contributor

T4rk1n commented Jul 12, 2023

Looks good, can you add a changelog entry?

@T4rk1n T4rk1n merged commit 6e8f50d into plotly:dev Jul 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] react-dom: Each child in a list should have a unique "key" prop
2 participants
@alexjercan @T4rk1n