Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Add hooks for layout "pre" and "post" #2630

Merged
merged 9 commits into from
Aug 25, 2023
Merged

Conversation

KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Aug 22, 2023

This PR adds new renderer hooks for users to write code that reads & updates the page layout.
In the same style as request_pre and request_post, there is now a layout_pre and a layout_post.

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@KoolADE85 KoolADE85 requested a review from T4rk1n August 22, 2023 18:44
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, just had a couple of minor comments!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants