Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dropdown menu max height fix #2892

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

aGitForEveryone
Copy link
Contributor

closes #2529
closes #2225

When a dash_table.DataTable is added to the dashboard (can be an empty table as well), css stylings are added to the Dash tool (see demonstration in #2529). These stylings override the max-height styling defined for the dropdown component, overriding the value set by the maxHeight property in dcc.Dropdown.

This fix changes the class names to which the css style is applied, so that the custom style set by Dropdown.css has higher priority than the dash_table.DataTable styling.

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows

… by the DataTable styling when it is added to the layout. Added test for checking this as well
@aGitForEveryone
Copy link
Contributor Author

Thanks @ann-marie-ward for the help with setting up this PR (and creating the fix)

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good.

@T4rk1n T4rk1n merged commit b13d9b8 into plotly:dev Jun 21, 2024
3 checks passed
@aGitForEveryone aGitForEveryone deleted the dropdown-menu-max-height-fix branch June 24, 2024 13:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants