Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added support for URL decoding of the search parameter for pages #2991

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

C0deBeez
Copy link
Contributor

@C0deBeez C0deBeez commented Sep 9, 2024

Here’s a structured PR description following the format you provided:


Description of this PR

This PR adds support for URL decoding of the search parameter in pages mode. The changes ensure that URL-encoded characters in the search parameter are properly decoded, improving the handling of query strings in pages mode.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Implement URL decoding for the search parameter in pages mode
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLs as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

This structure aligns with the given format and provides clear documentation of the changes.

@C0deBeez
Copy link
Contributor Author

C0deBeez commented Sep 9, 2024

This PR aims to correctly parse query parameters after URL encoding for pages.
eg: "%3fquery%3dsomething" should be decoded as {'query': 'something'}.

@gvwilson gvwilson added fix fixes something broken community community contribution P3 backlog labels Sep 9, 2024
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing a changelog entry.

@C0deBeez C0deBeez force-pushed the fix/add_unquote_for_pages branch from f9f2baf to e82247b Compare October 3, 2024 12:16
@C0deBeez
Copy link
Contributor Author

C0deBeez commented Oct 7, 2024

Looks good, just missing a changelog entry.

Changelog updated

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good thank you.

@T4rk1n T4rk1n merged commit a26eea5 into plotly:dev Oct 7, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community community contribution fix fixes something broken P3 backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants