Deprecate plugins #2995
Merged
Deprecate plugins #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
requested review from
alexcjohnson,
ndrezn,
gvwilson and
emilykl
as code owners
gvwilson
approved these changes
Sep 11, 2024
dash/dash.py
Outdated
| @@ -557,6 +557,12 @@ def __init__( # pylint: disable=too-many-statements | |||
| if plugins is not None and isinstance( | |||
| plugins, patch_collections_abc("Iterable") | |||
| ): | |||
| warnings.warn( | |||
| DeprecationWarning( | |||
| "plugins will be removed from Dash init in dash 3.0 and will be replaced by" | |||
There was a problem hiding this comment.
- "Plugins" (capital 'P' at the start of the sentence)
- "Dash 3.0" (rather than 'dash 3.0')
Other than that, 👍 from me.
There was a problem hiding this comment.
👍 It's the plugins keyword, let me change that.
gvwilson
approved these changes
Sep 11, 2024
dash/dash.py
Outdated
| if long_callback_manager: | ||
| warnings.warn( | ||
| DeprecationWarning( | ||
| "`long_callback_manager` is deprecated and will be remove in dash 3.0, " |
There was a problem hiding this comment.
"Dash 3.0" instead of "dash 3.0" for consistency please
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
pluginskeyword from the Dash__init__, will be removed in dash 3.0 in favor of a system that allows auto activation from pip installed package.I don't think the system was much used, the only documentation is from the
Dash.__init__docstring.