-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Performance improvement on (pattern-matching) callbacks #3009
Conversation
Awesome investigation @Spriteware , and an impressive first PR! Thank you for digging in here 🌟 |
There seems to be a side effect on the test: dash/components/dash-core-components/tests/integration/graph/test_graph_varia.py Line 684 in ef00323
The calls on lines dash/components/dash-core-components/tests/integration/graph/test_graph_varia.py Lines 716 to 721 in ef00323
happens before the graph render. If you add a time.sleep before the Draw a shape , it passes the test.
I think before this fix the |
Let's just add: dash/components/dash-core-components/tests/integration/graph/test_graph_varia.py Line 716 in ef00323
Then it's just missing a changelog entry and it's good to go 🚀 |
Hey @T4rk1n thank you for digging into the failing dcc tests. I wasn't sure what to do, as the main dash tests were passing locally. And not sure if I had the time and energy to go through this as well. Excited if this gets merged! @chriddyp Thank you for your supportive comment. If you need more investigations for optimizations, my DMs on plotly forum are indeed opened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Looks good, thank you.
This is amazing @Spriteware ! This issue has annoyed me for ages. I can't wait for the next release 👯 |
This PR is related to the issue I described here : #3008
If I encountered performance limitation with pattern-matching callbacks, I think this PR can be beneficial for regular callbacks as well.
Contributor Checklist