Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove werkzeug upperbound #3095

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

marcstern14
Copy link

@marcstern14 marcstern14 commented Nov 27, 2024

werkzeug>=3.1 is compatible within the set flask boundaries. Removing the boundaries for werkzeug would allow for more flexible installations on deployed apps without triggering vulnerabilities.

`werkzeug>=3.1` is compatible within the set flask boundaries. Removing the boundaries for `werkzeug` would allow for more flexible installations on deployed apps without triggering vulernabilities.
@ndrezn
Copy link
Member

ndrezn commented Nov 27, 2024

We've had a few issues in the past with backwards incompatibilities in werkzeug causing issues in Dash (#1992) which led to the pin.

Could you open a ticket requesting that we release the upper bound for discussion? Want to make sure we get this right if we decide to change the dependency on werkzeug.

Add a `werkzeug` lower bound to ensure this vulnerability is not triggered: https://security.snyk.io/vuln/SNYK-PYTHON-WERKZEUG-8309092
@marcstern14
Copy link
Author

marcstern14 commented Nov 27, 2024

Yes will do! Thanks @ndrezn

edit: see issue here

@gvwilson gvwilson added P2 considered for next cycle fix fixes something broken dependencies Pull requests that update a dependency file labels Dec 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file fix fixes something broken P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants