Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add cache control header and cache busting urls to components suites. #387

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Add cache control header and cache busting urls to components suites. #387

merged 2 commits into from
Sep 19, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Sep 13, 2018

Fix #380.

  • Add Cache-Control header to files served by serve_component_suites.
  • Append a time modified query parameter to the components suites urls.

@T4rk1n T4rk1n requested review from ned2 and rmarren1 September 13, 2018 16:55
@ned2
Copy link
Contributor

ned2 commented Sep 17, 2018

I don't have much experience with cache busting, but seems ok to me 💃

@T4rk1n T4rk1n merged commit 4a3fd72 into master Sep 19, 2018
@T4rk1n T4rk1n deleted the cache-headers-fix branch February 1, 2019 02:41
@chriddyp chriddyp mentioned this pull request Feb 28, 2019
Merged
@alexcjohnson alexcjohnson mentioned this pull request Aug 15, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ned2 ned2 ned2 approved these changes

@rmarren1 rmarren1 Awaiting requested review from rmarren1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rk1n @ned2