Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dash 1.0 - Update version to 1.0.0a1 #457

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Conversation

valentijnnieman
Copy link
Contributor

@valentijnnieman valentijnnieman commented Nov 12, 2018

This PR bumps the version up to 1.0.0-rc1, so that it's in-sync with the other Dash repo's.

Relies on:
dash-renderer 1.0.0
dash-core-components 1.0.0
dash-html-components 1.0.0

===============
@Marc-Andre-Rivet is hijacking this existing PR from @valentijnnieman 😄

Fixes https://github.com/plotly/dash-core/issues/3

  • Bumps version to 1.0.0a1 instead of rc1 to better respect semver
  • There's no react deps versions to handle so this is just about tagging the version
  • Updated destination branch to release-v1
  • Not taking care of dev-requirements.txt yet

# Conflicts:
#	CHANGELOG.md
#	dash/version.py
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Update version to 1.0.0rc1 Update version to 1.0.0a1 Dec 17, 2018
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Update version to 1.0.0a1 Dash 1.0 - Update version to 1.0.0a1 Dec 17, 2018
@bpostlethwaite
Copy link
Member

So what's the story here? I see this thing is targeting release-v1 from 1.0.0-release so does this mean the dash repos will have a release-v1 branch and we'll be printing rc versions from those branches?
Not a blocking comment just curious.

@Marc-Andre-Rivet
Copy link
Contributor

@bpostlethwaite Yes. So while 1.0 is still not ready for prime time we will make development in the release-v1 branch. Once this branch is ready (becomes the new latest/greatest, officially released) we will spin-off a release-v0 branch in case we need to make fixes in v0 and we will merge release-v1 into master.

I'm just picking up the existing PRs and redirecting them / tuning them instead of restarting from scratch when possible.

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 2579c26 into release-v1 Dec 18, 2018
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 1.0.0-release branch September 25, 2019 10:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants