Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix _imports_.py generation #473

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Fix _imports_.py generation #473

merged 2 commits into from
Nov 29, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Nov 29, 2018

The generation for _imports_.py made a strange indentation for the __all__ key. This fix the indentation.

@nicolaskruchten @rmarren1 Please review

@rmarren1
Copy link
Contributor

rmarren1 commented Nov 29, 2018

💃 Looks good, I got it to print

from .App import App
from .Bar import Bar
from .Foo import Foo

__all__ = [
    "App",
    "Bar",
    "Foo"
]

Not sure what is wrong with the other one... was this causing errors? Should be tested here:

from default_namespace.MyComponent import MyComponent \
as MyComponent_buildtime
from default_namespace.A import A as A_buildtime

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Nov 29, 2018

I don't know what caused the errors, it's tested on the boilerplate and it was generating right but when I went to dcc it failed the tests with indentation before the __all__.

@T4rk1n T4rk1n merged commit 93f82c6 into master Nov 29, 2018
@T4rk1n T4rk1n deleted the fix-imports branch November 29, 2018 20:56
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
AnnMarieW pushed a commit to AnnMarieW/dash that referenced this pull request Jan 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants