Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add APIs for dash docs testings #918

Merged
merged 5 commits into from
Sep 10, 2019
Merged

add APIs for dash docs testings #918

merged 5 commits into from
Sep 10, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Sep 10, 2019

Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • add timeout argument in process runner
    • add wait_for_element_by_id
  • I have run the tests locally and they passed. (refer to testing section in contributing)

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follow

@byronz byronz marked this pull request as ready for review September 10, 2019 14:24
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, turning those hard-coded timeouts into params is 💰
💃

dash/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 again :)

Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
@byronz byronz merged commit 9f1271b into dev Sep 10, 2019
@byronz byronz deleted the dash-testing-docs branch September 10, 2019 22:51
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants