Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Address bug in remote CSS dependency handling #56

Closed
rpkyle opened this issue Mar 11, 2019 · 0 comments
Closed

Address bug in remote CSS dependency handling #56

rpkyle opened this issue Mar 11, 2019 · 0 comments
Assignees
Milestone

Comments

@rpkyle
Copy link
Contributor

rpkyle commented Mar 11, 2019

#53 introduced a get_package_mapping function to construct a map matching keys$package from the _dash-component-suites handler to a (currently loaded) R package which supplies the dependency (if present).

While JavaScript dependency handling appears to work as intended, the update was not tested against remote CSS dependencies. This should be resolved before asset serving is implemented.

The crux of the issue is that get_package_mapping currently requires that four pieces of information are available:

  • a dependency name
  • the dependency "package" name from the URL (which is generally ≠ to the R package name)
  • a list of dependencies in htmltools format
  • the R package name, registered within each element of the dependency list described above

A PR (#57) has been proposed to handle this potential issue, by asserting that dependencies have valid name, URL package, and R package information before constructing the package map.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant