Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validate list of dependencies prior to constructing package_map #57

Merged
merged 9 commits into from
Mar 14, 2019

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Mar 11, 2019

This PR proposes introducing a function called clean_dependencies to help ensure that the list of dependencies passed to get_package_mapping contains no elements which are missing one or more of the following:

  • a dependency name
  • the dependency "package" name from the URL (which is generally ≠ to the R package name)
  • a list of dependencies in htmltools format
  • the R package name, registered within each element of the dependency list described above

Closes #56.

@rpkyle rpkyle self-assigned this Mar 11, 2019
@rpkyle rpkyle requested a review from alexcjohnson March 11, 2019 18:13
R/utils.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rpkyle
Copy link
Contributor Author

rpkyle commented Mar 14, 2019

@nicolaskruchten suggested not 🔪 the remote URLs for the JavaScript dependencies, so I've removed that (last) commit from the stack.

@rpkyle rpkyle requested a review from alexcjohnson March 14, 2019 18:25
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rpkyle rpkyle merged commit 03e3704 into master Mar 14, 2019
@rpkyle rpkyle deleted the 0.0.4 branch March 14, 2019 18:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants