-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
New Orca-based static image export tutorials for plotly.py 3.2.0 #1058
Conversation
See https://bundler.io/v1.2/bundle_install.html ``` $ bundle install --path vendor/bundle ```
Content-wise this is great 👌 Only a couple minor suggestions,
@nicolaskruchten is the https://plot.ly/python/static-image-export/#supported-formats section required in the new doc? @jonmmease I'll pin the |
Thanks for taking a look @bcdunbar , Capitalizing the headers sounds fine if that's more consistent with our desired style. And updating the Your "Sypported formats" question did remind me that I want to pull in that Note/disclaimer about which traces support fully vectorized output. BTW, did you try out installing and running the examples notebooks? I'm still looking for testing feedback 🙂 |
- Title Case All Titles - Move Orca Management section next to Static Image Export - Uploaded notebooks to notebook_demo account and set notebook URLs
Ok, I just pushed an update that covers the comments above. But I have a couple of questions / notes.
Other note: The current version displayed in these notebooks is 3.2.0a2, so I'll need to regenerate them using a branch that displays the version as 3.2.0. Thanks! |
It doesn't look like the Firefox notebook download is a known issue - definitely worth opening an issue.
I've come across a few of these that I haven't been able to find. For those, we add a new file here https://github.com/plotly/documentation/tree/source-design-merge/_posts/python/redirects and add a redirect. For example,
I think this may be the custom notebook css that is applied https://github.com/plotly/documentation/blob/source-design-merge/scss/_components/_highlighting.scss |
Yup, everything worked as expected. I'm on a windows machine so only the export of EPS doesn't work for me but the error message is super clear about why 👍 |
The only error I can see some users making between these two docs, is if they start with |
Firefox issue at #1060 |
Hmm, it looks like the highlighting culprit is highlight.js. Looks like it's auto-detecting those code block as SQL. When I totally disable it for this page everything looks fine. The Python code is highlighted by the notebook and nbconvert. Do you know when highlight.js is supposed to be helpful? I image it's might be needed for other languages, but I wonder if we could disable it for the Python pages since Jupyter/nbconvert takes care of this. |
Jupyter+nbconvert take care of this, and highlight.js can mess up code blocks specified without syntax highlighting.
Ok, I made a few updates.
What do you think? |
I'm fine with it - I had a look through a few docs and removing highlight.js doesn't seem to be an issue. @cldougl might have a better idea about this though.
Yeah this is great too. Because you edited the scss file, you'll need to update Once that is done and notebooks regenerated with 3.2.0 version, it is a 💃 from me. Thanks for making all these additional styling commits 🙇 |
Redirect for mystery page here: |
Alright, notebooks re-generated (and re-uploaded) and CSS built with gulp and committed. I also tested to verify that the new redirect is working. So for this to go live on ~Tuesday of next week, when should this be merged? Thanks for your help @bcdunbar! |
No worries @jonmmease You can merge it into |
Great, I'll merge as soon as I'm confident there are no blockers for the release. Also, how do we update the "Full Reference"? I'd like to bump that up to plotly.js 1.40.1 as well. |
Alright, going to merge this now. Tentative deploy target of tomorrow, but that may slip until Thursday. |
@jonmmease Full Reference is updated on deploy from the v2 plot schema endpoint: https://api.plot.ly/v2/plot-schema |
Overview
This PR contains two tutorials covering the new orca-based static image export functionality coming to plotly.py 3.2.0 (Not release yet).
See plotly/plotly.py#1120 for the corresponding PR in plotly.py.
Tutorials
Static Image Export
The legacy Static Image Export tutorial in the Plotly Fundamentals section has been overwritten by a new orca-based tutorial. This page is already the first google search result for "plotly image export", so this is the new page we want people to find first.
This tutorial covers installation instructions and the new
plotly.io.to_image
andplotly.io.write_image
functions.Orca Management
In addition, a new Orca Management tutorial has been added to the Plotly Fundamentals section.
This tutorial covers the lower level API for managing the orca server process.
Thumbnails
Thumbnails have been created and uploaded to S3
Notebooks
Timeline
If possible, I would like to work to get this PR reviewed and in final form by the end of this week. I'm aiming to release plotly.py 3.2.0 next Monday or Tuesday (Sept 3rd, or 4th), and I'd like to have these tutorials deployed just before the announcement.
Also, please try out the orca integration! plotly.py 3.2.0 alpha 2 is on PyPI and the anaconda plotly channel. See current instructions at https://github.com/jonmmease/plotly_orca_notebooks
cc @chriddyp @jackparmer