Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Commit

Permalink
Merge pull request #405
Browse files Browse the repository at this point in the history
  • Loading branch information
n-riesco authored Mar 24, 2018
2 parents 80590c1 + cc5ec49 commit 3ffc80d
Show file tree
Hide file tree
Showing 25 changed files with 1,481 additions and 2,177 deletions.
33 changes: 33 additions & 0 deletions CODING_GUIDELINES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Coding Guidelines

This is a live document that collects those coding guidelines we intend new code
to follow.


## ESLint

- Run `yarn lint` to validate your code.

- Don't commit code with ESLint errors (it'll make the build in CircleCI fail).

- Code with ESLint warnings won't make the build in CircleCI fail, but reviewers
will likely request they're fixed before merging a contribution.


## Naming Conventions

### Path and Filenames

- Use lower case names and only alphanumeric characters (unless required
otherwise).

- Avoid stuttering:
- bad: `my-connector/my-connector-driver.js`
- good: `my-connector/driver.js`

- Use the extension `.jsx` for files that contain JSX and `.js` for those that
only contain JavaScript.

### Variable and Function Names

- Use JavaScript convention, i.e. camelCase.
205 changes: 0 additions & 205 deletions app/components/Settings/Preview/ChartEditor.react.js

This file was deleted.

Loading

0 comments on commit 3ffc80d

Please # to comment.