Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

ChartEditor: use react-chart-editor #405

Merged
merged 21 commits into from
Mar 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions CODING_GUIDELINES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Coding Guidelines

This is a live document that collects those coding guidelines we intend new code
to follow.


## ESLint

- Run `yarn lint` to validate your code.

- Don't commit code with ESLint errors (it'll make the build in CircleCI fail).

- Code with ESLint warnings won't make the build in CircleCI fail, but reviewers
will likely request they're fixed before merging a contribution.


## Naming Conventions

### Path and Filenames

- Use lower case names and only alphanumeric characters (unless required
otherwise).

- Avoid stuttering:
- bad: `my-connector/my-connector-driver.js`
- good: `my-connector/driver.js`

- Use the extension `.jsx` for files that contain JSX and `.js` for those that
only contain JavaScript.

### Variable and Function Names

- Use JavaScript convention, i.e. camelCase.
205 changes: 0 additions & 205 deletions app/components/Settings/Preview/ChartEditor.react.js

This file was deleted.

Loading