Prevent RColorBrewer::brewer.pal warning #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RColorBrewer::brewer.pal()` throws an (in this case) unnecessary warning if the output plot requires less than 2 colors. This is an easy fix, and does not change the workings of the code since `RColorBrewer::brewer.pal()` never returns less than three levels anywas: ``` > RColorBrewer::brewer.pal(2, "Set2") [1] "#66C2A5" "#FC8D62" "#8DA0CB" Warning message: In RColorBrewer::brewer.pal(2, "Set2") : minimal value for n is 3, returning requested palette with 3 different levels ```
|
Thanks! |
cpsievert
added a commit
that referenced
this pull request
Jun 5, 2025
cpsievert
added a commit
that referenced
this pull request
Jun 5, 2025
* Follow up to #1999: update test expectation to not expect warning * Temporarily test against CRAN ggplot2 * Avoid :: on old ggplot2 function * Disable oldrel-4; roxygen stuff * Update URL * Try to fix kaliedo install * Fix more roxygen issues * Pass data to use_defaults() method (this way GeomSf default aes logic will actually work as expected) * Approve new snapshots * Revert "Pass data to use_defaults() method (this way GeomSf default aes logic will actually work as expected)" This reverts commit 01e73fb.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RColorBrewer::brewer.pal()throws an (in this case) unnecessary warning if the output plot requires less than 2 colors. This is an easy fix, and does not change the workings of the code sinceRColorBrewer::brewer.pal()never returns less than three levels anywas: