Isolate names(...) in event_data() to prevent spurious updates
#2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvg-p4
changed the title
dvg-p4
changed the title
names(session$userData$plotlyInputStore) to prevent spurious updates
dvg-p4
changed the title
names(session$userData$plotlyInputStore) to prevent spurious updatesnames(...) in event_data() to prevent spurious updates
|
@cpsievert is there anything else you'd like to see in the PR before approving the workflow / reviewing it? |
|
Thanks! Will you also add a |
|
@cpsievert done! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2337 by wrapping
names(session$userData$plotlyInputStore)withshiny::isolate().I don't think there's any good way to write an automated test for this, but you can verify that the reprex I gave in the issue no longer produces the spurious updates, while the click data continues to be correctly displayed.