Merge branch 'fix-deprecated-tests' of https://github.com/plotly/plot…

…ly.js into fix-deprecated-tests
plotly · Jan 21, 2025 · 6cab6be · 6cab6be
2 parents 7c418a5 + a6dcc4f
commit 6cab6be
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/test/jasmine/assets/mouse_event.js b/test/jasmine/assets/mouse_event.js
@@ -2,9 +2,9 @@ var Lib = require('../../../src/lib');
 
 module.exports = function(type, x, y, opts) {
     var visibility = document.visibilityState;
-    if(visibility && visibility !== 'visible') {
-        throw new Error('document.visibilityState = "' + visibility + '" - Please make the window visible.');
-    }
+    // if(visibility && visibility !== 'visible') {
+    //     throw new Error('document.visibilityState = "' + visibility + '" - Please make the window visible.');
+    // }
 
     var fullOpts = {
         bubbles: true,

diff --git a/test/jasmine/tests/plot_api_react_test.js b/test/jasmine/tests/plot_api_react_test.js
@@ -183,7 +183,7 @@ describe('@noCIdep Plotly.react', function() {
         Plotly.newPlot(gd, data, layout)
         .then(countPlots)
         .then(function() {
-            layout.title.text = 'XXXXX';
+            layout.title = { text: 'XXXXX' };
             layout.hovermode = 'closest';
             data[0].marker = {color: 'rgb(0, 100, 200)'};
             return Plotly.react(gd, data, layout);

diff --git a/test/jasmine/tests/sankey_test.js b/test/jasmine/tests/sankey_test.js
@@ -816,8 +816,8 @@ describe('sankey tests', function() {
 
                 var g = d3Select('.hovertext');
                 var pos = g.node().getBoundingClientRect();
-                expect(pos.x).toBeCloseTo(279, -1.5, 'it should have correct x position');
-                expect(pos.y).toBeCloseTo(500, -1.5, 'it should have correct y position');
+                expect(pos.x).toBeCloseTo(279, -1.5);
+                expect(pos.y).toBeCloseTo(500, -1.5);
             })
             .then(done, done.fail);
         });
@@ -1513,7 +1513,7 @@ function assertLabel(content, style) {
 
 function assertMultipleLabels(contentArray, styleArray) {
     var g = d3SelectAll('.hovertext');
-    expect(g.size()).toEqual(contentArray.length, 'wrong number of hoverlabels, expected to find ' + contentArray.length);
+    expect(g.size()).toEqual(contentArray.length);
     g.each(function(el, i) {
         _assertLabelGroup(d3Select(this), contentArray[i], styleArray[i]);
     });

diff --git a/test/jasmine/tests/select_test.js b/test/jasmine/tests/select_test.js
@@ -1996,7 +1996,10 @@ describe('Test select box and lasso per trace:', function() {
 
         return function(expected) {
             var msg = '(call #' + callNumber + ') lasso points ';
-            var lassoPoints = selectedData.lassoPoints || {};
+            var lassoPoints = {};
+            if (selectedData && selectedData.lassoPoints) {
+                lassoPoints = selectedData.lassoPoints;
+            }
 
             if(subplot) {
                 expect(lassoPoints[subplot] || [])