Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix react to plot_bgcolor changes #4816

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix react to plot_bgcolor changes #4816

merged 1 commit into from
May 6, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 6, 2020

Fixes #4807
Demo: before | after.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 6, 2020
@archmoj archmoj added this to the v1.54.3 milestone May 6, 2020
@archmoj archmoj requested a review from alexcjohnson May 6, 2020 20:48
alexcjohnson
alexcjohnson approved these changes May 6, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj modified the milestones: v1.54.3, v1.54.2 May 6, 2020
@archmoj archmoj merged commit af8f15f into master May 6, 2020
@archmoj archmoj deleted the react-plot_bgcolor branch May 6, 2020 22:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.54.2
Development

Successfully merging this pull request may close these issues.

react() and plot_bgcolor
2 participants
@archmoj @alexcjohnson