Fix rangebreaks on heatmap with 2d z array #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
May 8, 2020
| "2020-01-02 17:40", | ||
| "2020-01-02 17:50", | ||
| "2020-01-02 18:00", | ||
| "2020-01-02 18:10" |
There was a problem hiding this comment.
These tests include some removed data, which is good - but can we also include some data on the other side of the break, ie the next morning?
There was a problem hiding this comment.
Good call. Done in e2cf395.
|
Does this fix also support |
Not sure about that one. Is there any problem you noticed with |
|
I haven't tried |
- remove duplicate points from heatmap mocks
alexcjohnson
approved these changes
May 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4818 | demo: before vs after.
@plotly/plotly_js