Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bypass non-string ids when matching axes #4858

Merged
merged 1 commit into from
May 22, 2020
Merged

bypass non-string ids when matching axes #4858

merged 1 commit into from
May 22, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 22, 2020

Fixes #4844

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 22, 2020
@archmoj archmoj added this to the v1.54.2 milestone May 22, 2020
alexcjohnson
alexcjohnson approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit a450d93 into master May 22, 2020
@archmoj archmoj deleted the fix4844-handle-bad-axis-anchor branch May 22, 2020 21:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.54.2
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson